Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes v1 Flutter Android embedding references #1116

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Removes v1 Flutter Android embedding references #1116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41d38ac
Removes v1 embedding references, bumps version
yaakovschectman Oct 30, 2024
db5552d
Removes v1 embedding
yaakovschectman Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flutter_sound/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## 9.16.3
## 9.16.4

- ## The [CHANGELOG file is here](https://flutter-sound.canardoux.xyz/changelog.html)

18 changes: 0 additions & 18 deletions flutter_sound/android/src/main/java/xyz/canardoux/fluttersound/FlutterSound.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import android.content.Context;
import androidx.annotation.NonNull;
import io.flutter.embedding.engine.plugins.activity.ActivityPluginBinding;
import io.flutter.plugin.common.PluginRegistry.Registrar;
import io.flutter.embedding.engine.plugins.FlutterPlugin;
import io.flutter.embedding.engine.plugins.activity.ActivityAware;
import io.flutter.plugin.common.MethodCall;
Expand Down Expand Up @@ -55,23 +54,6 @@ public void onMethodCall ( final MethodCall call, final Result result )
});
}


/**
* Plugin registration.
*/
public static void registerWith ( Registrar registrar )
{
if (registrar.activity() == null) {
return;
}
Flauto.androidContext = registrar.context ();
Flauto.androidActivity = registrar.activity ();

FlutterSoundPlayerManager.attachFlautoPlayer ( Flauto.androidContext, registrar.messenger () );
FlutterSoundRecorderManager.attachFlautoRecorder ( Flauto.androidContext, registrar.messenger () );
}


@Override
public void onDetachedFromEngine ( FlutterPlugin.FlutterPluginBinding binding )
{
Expand Down
2 changes: 1 addition & 1 deletion flutter_sound/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: flutter_sound
version: 9.16.3
version: 9.16.4
description: 'Europe Stand With Ukraine. Pray for Ukraine. A complete api for audio playback and recording. Audio player, audio recorder.'
#author: canardoux<[email protected]>
homepage: https://flutter-sound.canardoux.xyz/readme.html
Expand Down