Introduce a normalizer for conditions #577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a situation with a
has_many through
orhas_one through
association,cancancan
could produce more joins than necessary if the rules were poorly defined.e.g.
given the class:
and the following rules:
this was producing the following query:
The rules normalizer recognises this situation and normalizes the rules automatically into:
producing the following query instead:
The RuleNormalizer can be extended to allow also the usage of STI and solve the following issue: #532