Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ScummVM package creates scummvm.ini file incorrecty, resulting in persistance not working #1073

Closed
3 tasks done
elisimpson opened this issue Dec 13, 2023 · 0 comments · Fixed by #1095
Closed
3 tasks done
Labels
bug Something isn't working

Comments

@elisimpson
Copy link

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues/PRs to ensure it has not already been reported or fixed.
  • I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

scummvm

Expected/Current Behaviour

scummvm manifest results in a scummvm.ini folder, not file, being created. ScummVM expects a file scummvm.ini in the application folder to run in portable mode.

Steps to Reproduce

Install scummvm
Note that scummvm.ini folder is created instead of file.
When ScummVM is run it will attempt to use the user profile directory instead of the application directory because no scummvm.ini file is present.

Possible Solution

Change manifest to create an empty scummvm.ini file instead of folder.

Scoop and Buckets Version

Current Scoop version:
v0.3.1 - Released at 2022-11-15

'extras' bucket:
09f4ad640 (HEAD -> master, origin/master, origin/HEAD) okular: Update to version 23.08.4-1608

'games' bucket:
a31352cb0 (HEAD -> master, origin/master, origin/HEAD) duckstation-preview: Update to version 20231213-g68d3cb5

'main' bucket:
9f504d662 (HEAD -> master, origin/master, origin/HEAD) vcpkg: Update to version 2023.12.12

Scoop Config

last_update       : 2023-12-13T15:55:25.1524818+09:00
use_external_7zip : True
cat_style         : full
scoop_branch      : master
scoop_repo        : https://github.com/ScoopInstaller/Scoop

PowerShell Version

Name                           Value
----                           -----
PSVersion                      5.1.22621.2506
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.22621.2506
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Additional Softwares

No response

@elisimpson elisimpson added the bug Something isn't working label Dec 13, 2023
shana added a commit to shana/scoop-games that referenced this issue Feb 22, 2024
ScummVM has changed the structure of the zip, the app is now in
a folder inside the zip. Add a pre_install step to move the contents
of this folder into the installation directory.

Also fix the persistence of the ini file, it was being created as
a folder and not a file.

Fixes Calinou#1073
shana added a commit to shana/scoop-games that referenced this issue Feb 22, 2024
ScummVM has changed the structure of the zip, the app is now in
a folder inside the zip. Add a pre_install step to move the contents
of this folder into the installation directory.

Also fix the persistence of the ini file, it was being created as
a folder and not a file.

Fixes Calinou#1073 Calinou#1094
shana added a commit to shana/scoop-games that referenced this issue Feb 22, 2024
ScummVM has changed the structure of the zip, the app is now in
a folder inside the zip. Add a pre_install step to move the contents
of this folder into the installation directory.

Also fix the persistence of the ini file, it was being created as
a folder and not a file.

Fixes Calinou#1073 Calinou#1094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant