Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added datasets to showcase the canvas overview renderer #19

Open
wants to merge 6 commits into
base: taggle-fusion
Choose a base branch
from

Conversation

domdir
Copy link

@domdir domdir commented Sep 7, 2018

Summary

Added two ordino datasets to showcase the canvas overview renderer:
image

image

Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When building the project for production using npm run build the large Ordino CSV files causing the following error (and creates an infinite loop):

Starting type checking service...
Using 1 worker with 2048MB memory limit

<--- Last few GCs --->

[16156:000002A632C7B1E0]    63814 ms: Mark-sweep 1566.8 (1625.4) -> 1566.8 (1594.4) MB, 1356.2 / 0.0 ms  last resort GC in old space requested
[16156:000002A632C7B1E0]    64916 ms: Mark-sweep 1566.8 (1594.4) -> 1566.8 (1594.4) MB, 1101.1 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 000000A5E8D25879 <JSObject>
    2: replace(this=0000022C0AC2A2A1 <Very long string[35064531]>,000001E59CD85739 <JSRegExp <String[44]: [\\\b\f\n\r\v\t\x22\x27\u2028\u2029\0\ufeff]>>,000001E59CD85771 <JSFunction (sfi = 000001A09E8F7129)>)
    3: make_string(aka make_string) [0000034BAA1822D1 <undefined>:5645] [bytecode=000001A09E8F7219 offset=55](this=0000034BAA1822D1 <undefined>,str=0000022C0AC2A2A1 <Very long string[3506...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node_module_register
 2: v8::internal::FatalProcessOutOfMemory
 3: v8::internal::FatalProcessOutOfMemory
 4: v8::internal::Factory::NewRawOneByteString
 5: v8::internal::Smi::SmiPrint
 6: v8::internal::StackGuard::HandleInterrupts
 7: v8::internal::interpreter::BytecodeArrayRandomIterator::UpdateOffsetFromIndex
 8: 000000C141C843C1

Further solutions are discussed here and here, but had no effect in my test.

I assume the error occurs because the whole file needs to be loaded in order to create a hash.

As workaround the project can be build in development mode using npm run build:dev however, this will skip some other optimizations.

In the future the CSV files should be excluded from the webpack build and loaded as external assets.

`;
},
build(node: HTMLElement) {
return import('raw-loader!./ordino1.csv').then((content: any) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import needs to be changed to avoid the webpack include.

`;
},
build(node: HTMLElement) {
return import('raw-loader!./ordino2.csv').then((content: any) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import needs to be changed to avoid the webpack include.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants