Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Prevalence Operation #27

Merged
merged 14 commits into from
Apr 7, 2022
Merged

Conversation

PatrickAdelberger
Copy link
Member

@PatrickAdelberger PatrickAdelberger commented Apr 5, 2022

closes Caleydo/cohort#666
closes Caleydo/cohort#588

Summary

Update the layout of the prevalence task:

  1. Moved the legend above the bar visualization
  2. Added the definition of the input cohorts with inmutable operation selection
  3. Updated operations design that define the reference cohort
  4. Updated loading icon and its animation
  5. Updated the scale/labels for the bar visualization, both are now on the right side of the ruler
  6. Added tranisition animation to highlight the changes
  7. Show/Hide base cohort
  8. Update tooltip for bar and prevalence value: added the confidence interval level of 95%
  9. Additional small style changes: legend mark, bar height, ...

Code Changes

  • package.json: updated d3 array, format, selection and added the transition package, additionally updated the types for those in the devDependencies
  • src/Cohort.ts: added function to get the formatet cohort label as a HTML string
  • src/Taskview/SearchBar.ts: updated the d3 selection.on() function due to the new version changes
  • src/Taskview/SearchColumn.ts: updated the d3 selection.on() function due to the new version changes
  • src/Taskview/tasks/Filter.ts: updated the d3 selection.on() function due to the new version changes
  • src/app.ts: updated the d3 selection.on() function due to the new version changes
  • src/Taskview/tasks/Prevalence.ts: changes for the prevalence operation
  • src/scss/components/task/_prevalence.scss: style changes for the prevalence operation

Implementation

GIF
27_improve_prevalence

Updated layout of legend (+ operations) and bars

before
image

now
image

Update scale

before
image

now
image

Hide base dataset + transition animations

before
These features did not exist before

now
tranistion_animation

@PatrickAdelberger PatrickAdelberger marked this pull request as draft April 5, 2022 12:51
@PatrickAdelberger PatrickAdelberger added release: major PR merge results in a new major version type: feature New feature or request type: refactor Refactor the current implementation labels Apr 5, 2022
@PatrickAdelberger PatrickAdelberger self-assigned this Apr 5, 2022
@PatrickAdelberger PatrickAdelberger marked this pull request as ready for review April 5, 2022 14:09
@PatrickAdelberger PatrickAdelberger added release: minor PR merge results in a new minor version and removed release: major PR merge results in a new major version labels Apr 6, 2022
@keckelt keckelt changed the base branch from main to develop April 7, 2022 07:23
Copy link
Member

@keckelt keckelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 💯

@PatrickAdelberger PatrickAdelberger merged commit 9fc2d0c into develop Apr 7, 2022
@PatrickAdelberger PatrickAdelberger deleted the prevalence_improv branch April 7, 2022 08:03
@mstreit
Copy link
Member

mstreit commented Apr 7, 2022

very nice!

@dvvanessastoiber dvvanessastoiber mentioned this pull request Apr 29, 2022
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: minor PR merge results in a new minor version type: feature New feature or request type: refactor Refactor the current implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants