-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Prevalence Operation #27
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickAdelberger
added
release: major
PR merge results in a new major version
type: feature
New feature or request
type: refactor
Refactor the current implementation
labels
Apr 5, 2022
PatrickAdelberger
added
release: minor
PR merge results in a new minor version
and removed
release: major
PR merge results in a new major version
labels
Apr 6, 2022
keckelt
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work 💯
very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: minor
PR merge results in a new minor version
type: feature
New feature or request
type: refactor
Refactor the current implementation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes Caleydo/cohort#666
closes Caleydo/cohort#588
Summary
Update the layout of the prevalence task:
Code Changes
package.json
: updated d3 array, format, selection and added the transition package, additionally updated the types for those in the devDependenciessrc/Cohort.ts
: added function to get the formatet cohort label as a HTML stringsrc/Taskview/SearchBar.ts
: updated the d3 selection.on() function due to the new version changessrc/Taskview/SearchColumn.ts
: updated the d3 selection.on() function due to the new version changessrc/Taskview/tasks/Filter.ts
: updated the d3 selection.on() function due to the new version changessrc/app.ts
: updated the d3 selection.on() function due to the new version changessrc/Taskview/tasks/Prevalence.ts
: changes for the prevalence operationsrc/scss/components/task/_prevalence.scss
: style changes for the prevalence operationImplementation
GIF
Updated layout of legend (+ operations) and bars
before
now
Update scale
before
now
Hide base dataset + transition animations
before
These features did not exist before
now