Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrollbar in Filter/Split #22

Merged
merged 6 commits into from
Mar 23, 2022
Merged

Fix scrollbar in Filter/Split #22

merged 6 commits into from
Mar 23, 2022

Conversation

keckelt
Copy link
Member

@keckelt keckelt commented Mar 15, 2022

based on #21
part of https://github.com/Caleydo/cohort/issues/666

The Filter/Split sidepanel became larger and has overflown the grid area, likely due to the update to BS5.
I've adapted the grid sizing, and additionally added some space for potential vertical scrollbars.

@keckelt keckelt marked this pull request as ready for review March 15, 2022 10:17
@keckelt keckelt self-assigned this Mar 21, 2022
Copy link
Member

@PatrickAdelberger PatrickAdelberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay 👍

@keckelt keckelt merged commit accb674 into develop Mar 23, 2022
@keckelt keckelt deleted the scrollbar-fix branch March 23, 2022 19:54
@dvvanessastoiber dvvanessastoiber mentioned this pull request Apr 29, 2022
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants