Fix dry run sql output. #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent aborting loop too early, therefore outputting all sql instead of just the first query.
|
This has already been fixed in the develop branch. |
|
I see, but there are a few places where dry run is still aborting foreach loop. Like in CakeMigration::_alterTable(), CakeMigration::_renameTable(), CakeMigration::_alterIndexes(). |
|
OK, I see now, please re-open the PR against the |
|
I fixed it myself now in develop . #183 Thank you for showing the other places as well! |
|
Thank you :) |
deizel
pushed a commit
to deizel/cakedc-migrations
that referenced
this pull request
Mar 4, 2016
Update the Migrations class to support the seeding feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent aborting loop too early, therefore outputting all sql instead of
just the first query.