Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Low latency dash support #3
Low latency dash support #3
Changes from 10 commits
bf0d4b8
a1d95b6
a6667ae
7a383ea
75cdccb
b6b2e75
7e69ed4
40e6c55
7723b85
19b9b8c
8b17058
76505e4
a8e9661
06ef351
fd1724d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
design nit: I tend to think that "is" belongs on boolean getters, to see the state of a thing. For a declaration like this to instruct the pipeline to do something, I would call it something like "low_latency_mode". I would also make it apply to both DASH & HLS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I totally agree. I'll change it to "low_latency_dash_mode" for now since my Packager fork supports only LL-DASH. HOWEVER! :D I was tinkering this weekend and made promising progress for LL-HLS support! 🥳 I'll finish that up, and once LL-HLS is working, I'll comb over the naming/comments/logic to make sure everything is changed to general "low latency" rather than LL-DASH specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I might prefer replacing the scheme ID with a more readable enum, in the name of making the config files easier to write, but I don't think it's worth holding up this PR. Something to consider for later, though, if you have time.
I think we would restrict that enum to values equivalent to the "xsdate" and "head" schemes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh, I like the idea of using an enum - I'll make sure to add it later.
The UTCTiming information is funky to format and very easy to mess up. The standard lists the following as the possible options.
https://dashif-documents.azurewebsites.net/DASH-IF-IOP/master/DASH-IF-IOP.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, but we wouldn't have to offer all of those. I think xsdate and head are the simplest and easiest to explain in docs, and should cover most people's needs. For Streamer, I would tend to err on the side of "easy" and add power later if people request it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This await is never resolved causing the test to fail :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can debug in the http server in the python script that runs the tests to see what requests the player is making. That might give us a clue as to what's wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this insight! I will check it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I figured out the issue! The
run_end_to_end_tests.py
process will sleep until the DASH or HLS stream is ready for playout. The readiness for the DASH case is determined by the functiondashStreamsReady()
. This function uses regex to check the MPD for the presence of a segment tag<S>
, which indicates that a segment is available. LL-DASH MPDs do not contain<S>
, so the LL-DASH stream was never able to trigger the ready state.To fix this, I added a check for the
availableTimeOffset
attribute in the LL-DASH case. This attribute is equal to the segment duration minus the chunk duration. TheavailableTimeOffset
value indicates to the player the earliest time that a segment can be played out, since, in the LL-DASH case, the segment can be downloaded and played before it is fully written.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix looks good. Nice work!