Cache serialized version of Attribute to save on space #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alukach
force-pushed
the
bugfix/caching-issues
branch
from
40119ba to
1448328
Compare
alukach
force-pushed
the
bugfix/caching-issues
branch
from
1448328 to
42cd728
Compare
46 tasks
|
Partially resolves Cadasta/cadasta-platform#1579. This change avoids errors without needing Cadasta/cadasta-platform#1650, however both are recommended as a) we want to use caching when we can as it was likely added for a good reason; and b) eventually someone will try to put a huge object into cache. |
alukach
changed the title
amplifi
approved these changes
Jul 13, 2017
oliverroick
approved these changes
Jul 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cadasta/cadasta-platform#1579 occurs when attempting to cache a large number of
Attributeinstances (407 in the case of the ticket's example). When serialized by the Python memcached library (via Pickle, I believe), this large number of model instances exceeded the 1MB limit of memcached This PR helps us avoid the failure by serializing/deserializingAttributeinstances as lighter-weight dictionary objects rather than entire Django Model instances (along with their FK related model instances, I believe) when inserting/retrieving them to/from the cache.