Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org admin cannot archive own project #1752

Closed
seav opened this issue Aug 29, 2017 · 9 comments
Closed

Org admin cannot archive own project #1752

seav opened this issue Aug 29, 2017 · 9 comments

Comments

@seav
Copy link
Contributor

seav commented Aug 29, 2017

Steps to reproduce the error

I don't know how to reproduce this, but this is happening on staging. I think this was a side-effect of the tutelary replacement branch testing. I am an org administrator for a project (see 1st screenshot below), but when I try to archive a project, I get a denied error message (see 2nd screenshot below).

screen shot 2017-08-29 at 23 46 55

screen shot 2017-08-29 at 23 47 08

Actual behavior

Org admin cannot archive a project in their org.

Expected behavior

Org admin should be able to archive a project in their org.

@oliverroick
Copy link
Member

Have you created that project before the permissions branch went on staging? I can archive projects in an org I have created today.

@seav
Copy link
Contributor Author

seav commented Aug 29, 2017

I created that project today, but the organization and the admin account existed before the permissions branch went on staging.

@amplifi
Copy link
Contributor

amplifi commented Aug 29, 2017

I can archive projects on orgs pre- and post- permissions branch. In your screenshot, the account is listed as admin but has different non-admin project roles. In viewing the organization's member list now, it shows you as a member with project manager roles:

screen shot 2017-08-29 at 5 12 01 pm

It looks like somewhere in testing with your organization, user permissions got modified, but this is unrelated to the permissions branch.

@seav
Copy link
Contributor Author

seav commented Aug 29, 2017

OK. So there is definitely some weirdness going on and a most likely an inconsistency in the database. Only an org admin can create projects and view the org membership page (otherwise, I wouldn't be able to take that screenshot) or create the "QA Day Test Project", which I was trying to archive. So my account is being treated as an org admin in some respects but as a non-org admin in other respects.

@dpalomino
Copy link

Thanks @seav. Definitely it seems related with #1754. In my case, if you create a new organization then behaviour was fine, but with previously existing orgs it was failing.

@oliverroick oliverroick self-assigned this Aug 30, 2017
@amplifi
Copy link
Contributor

amplifi commented Aug 30, 2017

Ref: #1754 (comment)

@oliverroick
Copy link
Member

@seav Can you walk me through the steps you took to get to this stage? I can reproduce David's bug but not yours.

@seav
Copy link
Contributor Author

seav commented Aug 31, 2017

@oliverroick, I can't remember if I did anything to get this bug so I stated above that "I don't know how to reproduce this". I definitely did not attempt to remove my account's administrator status during testing. But if your explanation in #1754 is correct, then this bug seems to make sense. Only org admins can archive/unarchive projects and while I was able to create a project (which is probably related to my existing tutelary project.create permission tied to the organization), my tutelary permissions denied me the permission to archive that project because my org role is that of a member instead of an admin and the tutelary project.archive permission is tied to the newly-created project and not to the preexisting org.

@oliverroick
Copy link
Member

Not able to reproduce. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants