Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect values to sign in and register links in header #1671

Closed
SteadyCadence opened this issue Jul 22, 2017 · 7 comments · Fixed by #1713
Closed

Add redirect values to sign in and register links in header #1671

SteadyCadence opened this issue Jul 22, 2017 · 7 comments · Fixed by #1713

Comments

@SteadyCadence
Copy link

Just an annoyance I deal with each time I am working on a partner account.

  1. I go to an org page.
  2. Unable to access because not signed in.
  3. Sign in.
  4. Taken to homepage. Have to deal with the struggle of finding the project page again.

Will this be fixed with the new personal dashboard... ?

@dpalomino
Copy link

Related with #1491.

I think it will mostly addressed with this subtask for the user dashboard:

"Returning users will be able to view the specific organizations and projects they are members of as well as their assigned permission level"

As most of real users (not Cadasta staff) will be just dealing with an organizaiton and a couple of projects, I think landing in the dashboard after signing in is going to be sufficient.

@SteadyCadence
Copy link
Author

This was def an issue when I was sitting next to partners. Everytime their session expired, which seems daily if not hourly, they would go to the URL and then be forced to sign in again and then get taken to the homepage where they had to figure out a way to find their project again.

I think the real issue is if someone is logged out and they go to a URL, when they sign back in they should be routed to that same URL. Other sites seem to be able to support that. We should as well. I think I may need to rename this issue to that. "Return to original URL after user signs in"

@clash99
Copy link
Contributor

clash99 commented Jul 25, 2017

I think this is a bug but can't tell from the description. Can you provide a screenshot or more detail of what page you are on when you link to sign in? Our org pages don't have a register/sign in button like the project pages (minus the header links).

Our site does redirect users back to where they were when they were prompted. Check out a project dashboard not logged in for an example.

@laura-barluzzi
Copy link
Contributor

Specifically, this is not going to be "fixed" by the user dashboard. The user dashboard would just reduce the "annoyance" of having to find the organization/project through the whole list of projects since you would access a filtered list on the user dashboard. I think this will fix the annoyance, but itself this issue seems to be related to the fact that you don't return to a page from where you are asked to log-in to access.

Normally, if you try to see one page (let's say the org X dashboard) but you are told "to see the dashboard, login" - if you log-in clicking there you should be returned to that specific org X dashboard. So I'd say this may be a bug.

@laura-barluzzi
Copy link
Contributor

Summarizing, if you click on Sign In here, you should land on this project Test Questionnaire instead of the my user dashboard.
image
Still, I think that this issue can be considered closed once the user dashboard is done since the annoyance of re-searching the project would be decreased 100%.

@amplifi
Copy link
Contributor

amplifi commented Aug 8, 2017

This is a quick fix and has nothing to do with the user dashboard. There's a disparity in the way the "Sign In" button under "Have an account?" on the project dashboard behaves vs the "Sign In" button in the upper righthand corner. The former includes the next parameter, the latter does not. If a user clicks the button in the upper righthand corner, they will be dumped back to the dashboard every time. User instinct is to click the "Sign In" button in the upper corner, because that's the first behavior they learn to accomplish this task and that button persists across every page.

We just need to add the next param to the "Sign In" button in that top button group.

@clash99
Copy link
Contributor

clash99 commented Aug 9, 2017

@amplifi Thanks for clarifying bug. I'm filing a PR for this.

@clash99 clash99 changed the title Question about personal dashboard feature :: Sign in annoyance Add redirect values to sign in and register links in header Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants