Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plus, minus and other forbidden chars are allowed in text attributes when they are not at the beginning of the string #1631

Closed
dpalomino opened this issue Jul 5, 2017 · 3 comments

Comments

@dpalomino
Copy link

dpalomino commented Jul 5, 2017

Steps to reproduce the error

Related with #1619

Plus (+), minus (-) and other signs (<, >, etc) are allowed in text fields when these are not at the begging of the field. For instance, the following text strings are rejected:

"-asdf"
"+asdf"
"++++asdf"

But these other ones are accepted:

"text+++text"
"text+----text"

This behaviour is the same when adding or editing a field via the web interface, or submitting records with ODK or geoODK.

See screenshot:
screen shot 2017-07-05 at 16 22 06

@seav
Copy link
Contributor

seav commented Jul 5, 2017

I think this is acceptable behavior. If you disallow this, you would be rejecting perfectly fine text like "Adolfo Suárez Madrid-Barajas Airport", "Guinea-Bissau", and "Olivia Newton-John".

@dpalomino
Copy link
Author

I think this is acceptable behavior. If you disallow this, you would be rejecting perfectly fine text like "Adolfo Suárez Madrid-Barajas Airport", "Guinea-Bissau", and "Olivia Newton-John".

Sounds good @seav, that's true. Thanks :-)

@amplifi
Copy link
Contributor

amplifi commented Jul 5, 2017

Expected behavior; closing.

@amplifi amplifi closed this as completed Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants