Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves #1072 Create ADP integration tests #1079

Merged
merged 29 commits into from
Jun 8, 2023
Merged

Resolves #1072 Create ADP integration tests #1079

merged 29 commits into from
Jun 8, 2023

Conversation

david-rocca
Copy link
Collaborator

@david-rocca david-rocca commented Jun 7, 2023 •
edited
Loading

Closes Issue #1072

Summary

Starting to implement integration test framework. Also implemented integration tests for #1063 as a first example.

Important Changes

insertAdpTest.js

Testing

Steps to manually test updated functionality, if possible

  • 1) Run the following command: npm run test:integration

David T Rocca added 28 commits June 8, 2023 10:58
#1072 Updated the package.json to have an npm command to populate the…
6bee990 
… test database env
#1072 Updated package.json to have new test and coverage commands
c443747 
Including tests for just running integration or unit tests.
Updated coverage to only calculate coverage for the src directory
Added coverage command to generate html coverage
#1072 Update the populate script and related scripts to populate the …
24034a4 
…test database similar to how population is done with the dev database
#1072 Exposing the express app context. Allowing use of it in integra…
410e71f 
…tion testing.
#1072 updated package.json so integration tests automatically reset t…
39fc1cb 
…he database on run
#1072 give a test org the ADP role
f9e8f67
#1072 Integration test for actually calling cve-id reservation endpoint
c05fcd7
#1072 Adding constants used across integration tests
9f3751e
#1072 Added integration test that calls the real reserveCve endpoints
e154a36
#1072 added integration test that tests the insert adp endpoint.
fa0363d
#1072 Removing excessive 'only'
2aabf76
#1072 added another org with the adp role to be able to test editing …
6afdac2 
…of adps
#1072 Migrated some repeated code into a helpers file
902c95f
#1072 Added additional tests to the adp insert tests, also added addi…
173c2b8 
…tional items to the constants js
Update test.yml workflow to only call the unit tests
98855e2
Create new workflow to run integration tests
f7ae16e
#1072 updated the correct test trigger for unit test workflow
d04c4e2
#1072 use a special docker env for the actions in the test env
056df98
#1072 attempt to work around chi / node fighting over port
76b3572
#1072 switch env for node to develop
62e5785
#1072 Fixed items found by linting test
f702362
#1072 Due to the way that mocha coverage starts up, we need to specif…
0a7e842 
…y that it is in the test env so it does not try to do any host crazy stuff
#1072 Update integration tests to return non 0
a7cc73d
#1072 setting a test to fail, to test github workflow
067b255
#1072 reverting test commit.
c99eee3
#1072 updated the coverage action to not return 1 on a less than 80 c…
1f8e8e9 
…overage
#1072 Update integration tests workflow to have a unique name for the…
03b5bee 
… job
#1072 update port control logic to use a ternary
803cb0c
@david-rocca david-rocca requested a review from jdaigneau5 June 8, 2023 15:00
@jdaigneau5 jdaigneau5 merged commit e42fc06 into dev Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdaigneau5 jdaigneau5 jdaigneau5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-rocca @jdaigneau5