Problems filtering reverse geocoding results

[vreixo]

This was discovered with #357 and the limitation to the app of using Android Geocoder.

Android Geocoder results are not always strictly in the bounding box, so the app does some filtering of these (and also of the other providers results), but as long as they are in the bounding box even if they are very far to the passed latitude and longitude they're going to be accepted and offered to the user.

I clearly think that this should be more strict when doing this reverse geocoding to discard Android Geocoder results if they are not close enough to the requested location, thus having the option of receive better results from other providers. Another option will be to keep Android Geocoder results but change the code to also get more results from other providers if these are bad.

If we have this, app will work even when the Android Geocoder returns these bad results.

[barbeau]

+1

[vreixo]

@barbeau I have some doubts about how to implement this.

1. Do you think that we should offer the user a result to choose when reverse geocoding?
2. If we autoselect, Do we choose the first one (will it be more important?) or the closest one?
3. If none of the results are "close enough" to the original location, again, do we choose the closest one and display it with "Marker close to ..."?

These are my opinions although I'm not sure at all:

1. I think that would be better to autoselect, it seems to me more logical that the app knows what point is the requested one and don't need the help of the user. Also when a marker is set I'm not sure if a user would expect a select dialog to appear. In fact I'm thinking on totally removing these dialogs, see Remove old geocoder results selector dialog #366.
2. I don't have any idea here, order may be important but is also very important to choose a close result.
3. I think so.

[barbeau]

Ah - I misread this as "geocoding", not reverse geocoding, when I first looked at it. I think these are my concerns that I just expressed here:
#357 (comment)

After you read that let me know if that doesn't answer your questions.