-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ADMM + parameter reordering FISTA #553
Add ADMM + parameter reordering FISTA #553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for splitting the PR into these smaller parts @jeverink!
I appreciate you adding this ADMM solver, including the adaptive scheme.
I know the current solver module is a bit lackluster with respect to code quality, but I was thinking that this PR can start moving the overall state of the solver module in a better direction. Therefore I added quite a bit of comments and suggestions.
Do not hesitate to reach out if you have questions on the comments.
Co-authored-by: Nicolai André Brogaard Riis <[email protected]>
Thanks for all the feedback @nabriis. I have now incorporated some of the feedback and like to have some feedback on some of the open conversations. The general issues your commented on summed up:
I also just noted that the two tests that fail seem to be are regarding sampling from the RegularizedGaussian/GMRF, which should not have been effected by the changes of this code. The only related change in this PR is a reordering of the parameters of FISTA (problem specific before algorithmic specific), but that should not cause these numerical issues. Do you see what might have gone wrong? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jeverink. I agree with your comments on code style etc. I created 3 issues. I only have a few comments left related to the code. I think we are nearly there! The refactor of the pre-processing was really helpful for readability. Thank you for adding the docstrings also!
Removal of accident copy-paste code
Co-authored-by: Nicolai André Brogaard Riis <[email protected]>
Thanks for the help @nabriis, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jeverink. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jeverink for your contribution, great work!
I made a few comments, please feel free to address them as you see fit and let me know if any of my comments are unclear.
Thanks for the feedback @amal-ghamdi, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jeverink! it looks great. I added one line suggestion in the description of the optimization functional and one comment about the documentation of the penalty_parameter for your consideration.
I am approving the PR.
Co-authored-by: amal-ghamdi <[email protected]>
By request, sub PR from #431
Added ADMM solver
closes #562