Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint22 update notebooks to reflect the change to get_components #79

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

chaozg
Copy link
Contributor

@chaozg chaozg commented Oct 29, 2023

Fixed #78

@chaozg chaozg requested review from amal-ghamdi and nabriis October 29, 2023 22:00
Copy link
Collaborator

@nabriis nabriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@amal-ghamdi amal-ghamdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chaozg for the PR. Looks great! I only had one minor suggestion.

training/Exercise05_PDE.ipynb Outdated Show resolved Hide resolved
Improve wording

Co-authored-by: amal-ghamdi <[email protected]>
@chaozg chaozg merged commit 92e0929 into main Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CUQIpy-demos to reflect the update in get_component
3 participants