Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 66 update exercise04 training for Oct 2023 #71

Merged
merged 10 commits into from
Oct 6, 2023

Conversation

nabriis
Copy link
Collaborator

@nabriis nabriis commented Sep 28, 2023

Closes #66

Updated prior distribution to GMRF to patch the example in CUQIpy paper I + many small updates on wording etc.

@nabriis nabriis changed the title Fix 66 update exercise04 training sept 2023 Fix 66 update exercise04 training for Oct 2023 Sep 28, 2023
Copy link
Contributor

@jakobsj jakobsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, really nice flow and explanations - the recent edits have improved it even more. Nice touch to add a link to the CUQIpy article, and changing to GMRF makes very good sense. Only found some tiny things added below. You might consider explicitly mentioning and referring to the online documentation somewhere in the beginning, also mentioning that there will be specific links later on.

training/Exercise04_Bayesian_Inverse_Problems.ipynb Outdated Show resolved Hide resolved
Copy link
Collaborator

@amal-ghamdi amal-ghamdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nabriis for this update and upgrading the notebook for more consistency and clarity! I had just some comments for your consideration.

training/Exercise04_Bayesian_Inverse_Problems.ipynb Outdated Show resolved Hide resolved
training/Exercise04_Bayesian_Inverse_Problems.ipynb Outdated Show resolved Hide resolved
training/Exercise04_Bayesian_Inverse_Problems.ipynb Outdated Show resolved Hide resolved
training/Exercise04_Bayesian_Inverse_Problems.ipynb Outdated Show resolved Hide resolved
training/Exercise04_Bayesian_Inverse_Problems.ipynb Outdated Show resolved Hide resolved
training/Exercise04_Bayesian_Inverse_Problems.ipynb Outdated Show resolved Hide resolved
training/Exercise04_Bayesian_Inverse_Problems.ipynb Outdated Show resolved Hide resolved
training/Exercise04_Bayesian_Inverse_Problems.ipynb Outdated Show resolved Hide resolved
training/Exercise04_Bayesian_Inverse_Problems.ipynb Outdated Show resolved Hide resolved
training/Exercise04_Bayesian_Inverse_Problems.ipynb Outdated Show resolved Hide resolved
@nabriis nabriis requested review from amal-ghamdi and jakobsj October 5, 2023 21:15
Copy link
Collaborator

@amal-ghamdi amal-ghamdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nabriis for the updates! LGTM and I am approving. I just left 2 comments about the likelihood and the physical model.

Copy link
Contributor

@jakobsj jakobsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nabriis nabriis merged commit 2a677b2 into main Oct 6, 2023
@nabriis nabriis deleted the fix_66_update_exercise04_training_Sept_2023 branch October 6, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Exercise 04 in training material
3 participants