[CBRD-25771] Add -i option to DIAGDB for input file and update usage message #5743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InChiJun
changed the title
YeunjunLee
reviewed
Dec 27, 2024
YeunjunLee
reviewed
Dec 27, 2024
YeunjunLee
reviewed
Dec 27, 2024
vimkim
reviewed
Dec 31, 2024
hornetmj
reviewed
Jan 8, 2025
YeunjunLee
approved these changes
Jan 20, 2025
InChiJun
force-pushed
the
CBRD-25771
branch
2 times, most recently
from
30116b4 to
69ef11a
Compare
H2SU
approved these changes
Jan 20, 2025
hornetmj
approved these changes
Jan 24, 2025
| { | ||
| goto print_diag_usage; | ||
| } | ||
| if (class_name && class_list_file) |
There was a problem hiding this comment.
Suggested change
| if (class_name && class_list_file) | |
| if (class_name && class_list_file) |
| { | ||
| fprintf (outfp, "\n*** DUMP OF ALL HEAPS ***\n"); | ||
| (void) file_tracker_dump_all_heap (thread_p, outfp, dump_records); | ||
| } | ||
| else | ||
| else if (class_name != NULL) |
There was a problem hiding this comment.
위에서 class_name와 class_list_file가 모두 NULL이 아닌 경우에 대한 예외처리를 수행했기 때문에 다음이 더 가독성이 좋을 수 있습니다. 다음 이슈 구현에 따라 달라질 수 있는 부분이니 해당 PR에서 고민해 보도록 하세요.
if (class_name != NULL) { // 이 경우 처리 }
else if (class_list_file != NULL { // 이 경우 처리}
else { // 전체 dump }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-25771
Purpose
-i 옵션에는 클래스명이 담긴 파일이 전달되어야 한다.
-i 옵션으로 전달된 파일을 인식할 수 있도록 한다.
-n 옵션과 -i 옵션을 동시에 실행시킬 수 없다.
Implementation
Remarks