Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-25765] System Catalog refactoring for consistency #5739

Closed
wants to merge 25 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
721ac8d
Remove duplicated macros in authenticate_constants.h
kangmin5505 Dec 23, 2024
34e209a
Replace literal varchar with format_varchar function.
kangmin5505 Dec 24, 2024
0817647
Rename functions for consistency with system catalog naming conventions.
kangmin5505 Dec 24, 2024
26f21d8
Refactor db_trigger System Catalog
kangmin5505 Dec 26, 2024
6ceab2c
Apply codestyle
kangmin5505 Dec 26, 2024
7107247
Merge remote-tracking branch 'upstream/develop' into CBRD-25765
kangmin5505 Dec 26, 2024
c85ac5c
Change column type for CT_DBCHARSET_CHAR_SIZE from "int" to "integer"
kangmin5505 Dec 26, 2024
673ec6f
Refactor function names for consistency
kangmin5505 Dec 26, 2024
5873b7f
Replace literal 1073741825 with SM_MAX_STRING_LENGTH macro
kangmin5505 Dec 30, 2024
4959c84
Merge remote-tracking branch 'upstream/develop' into CBRD-25765
kangmin5505 Dec 30, 2024
4d9511b
Fix wrong system catalog name(CT_PARTITION_NAME -> CT_DATATYPE_NAME)
kangmin5505 Jan 8, 2025
e4e6885
Merge remote-tracking branch 'upstream/develop' into CBRD-25765
kangmin5505 Jan 8, 2025
797e259
Remove unnecessary newlines from schema_system_catalog_install.cpp
kangmin5505 Jan 8, 2025
01e4b51
Refactor get_dual initializer
kangmin5505 Jan 8, 2025
15a2e54
Refactor struct db_object *class_mop to MOP class_mop for consistency
kangmin5505 Jan 8, 2025
f7b140b
Refactor system catalog header files
kangmin5505 Jan 8, 2025
3a93623
Apply codestyle
kangmin5505 Jan 8, 2025
2ae50e3
Refactor dvalue_func(default value initialization function) in system…
kangmin5505 Jan 8, 2025
f54f4fa
Fix system catalog definitions to correct names
kangmin5505 Jan 11, 2025
9d2cff0
Remove redundant sm_mark_system_classes function call.
kangmin5505 Jan 16, 2025
e547108
Merge remote-tracking branch 'upstream/develop' into CBRD-25765
kangmin5505 Jan 20, 2025
f8b91cf
Revert "Remove redundant sm_mark_system_classes function call."
kangmin5505 Jan 20, 2025
75df6d8
Remove redundant sm_mark_system_classes function call
kangmin5505 Jan 20, 2025
92e5e86
Merge remote-tracking branch 'upstream/develop' into CBRD-25765
kangmin5505 Jan 20, 2025
2f1013e
Apply codestyle
kangmin5505 Jan 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove redundant sm_mark_system_classes function call
kangmin5505 committed Jan 20, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 75df6d876adf4014dec574a535b710a8aedef04d
9 changes: 5 additions & 4 deletions src/object/schema_system_catalog_builder.cpp
Original file line number Diff line number Diff line change
@@ -42,10 +42,6 @@ namespace cubschema
if (sm_is_system_class (name))
{
class_mop = db_create_class (name.data ());
if (class_mop != nullptr)
{
sm_mark_system_class (class_mop, 1);
}
}
else if (sm_is_system_vclass (name))
{
@@ -56,6 +52,11 @@ namespace cubschema
assert (false);
}

if (class_mop != nullptr)
{
sm_mark_system_class (class_mop, 1);
}

return class_mop;
}

5 changes: 0 additions & 5 deletions src/transaction/boot_cl.c
Original file line number Diff line number Diff line change
@@ -557,11 +557,6 @@ boot_initialize_client (BOOT_CLIENT_CREDENTIAL * client_credential, BOOT_DB_PATH
error_code = catcls_install ();
if (error_code == NO_ERROR)
{
/*
* mark all classes created during the initialization as "system"
* classes,
*/
sm_mark_system_classes ();
error_code = tran_commit (false);
}