Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Use oldest Ubuntu and newest macOS #909

Closed
wants to merge 3 commits into from

Conversation

arichardson
Copy link
Member

This ensures that we can build on macOS 11.0
and the oldest supported Ubuntu release
(both of which were previously broken).

This ensures that we can build on macOS 11.0
and the oldest supported Ubuntu release
(both of which were previously broken).
pkgs: bmake libarchive-dev
- os: macOS-latest
- os: macos-11.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11 not 11.0 (now following an iOS-like versioning scheme)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the GitHub documentation is wrong then..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, actions/runner-images#2486. So the name is right, but it's a terrible one done without any proper thought.

@jrtc27
Copy link
Member

jrtc27 commented Jan 24, 2021

I think we want to keep the existing jobs? Certainly keeping a non-ancient Ubuntu would be good otherwise we risk regressing support for more modern glibcs.

@arichardson
Copy link
Member Author

arichardson commented Jan 24, 2021

I think we want to keep the existing jobs? Certainly keeping a non-ancient Ubuntu would be good otherwise we risk regressing support for more modern glibcs.

I agree we should but that's handled by our Jenkins tasks.

@jrtc27
Copy link
Member

jrtc27 commented Jan 24, 2021

I think we want to keep the existing jobs? Certainly keeping a non-ancient Ubuntu would be good otherwise we risk regressing support for more modern glibcs.

I agree we should but that's handled by our Jenkins tasks.

Not upstream.

@arichardson
Copy link
Member Author

I think we want to keep the existing jobs? Certainly keeping a non-ancient Ubuntu would be good otherwise we risk regressing support for more modern glibcs.

I agree we should but that's handled by our Jenkins tasks.

Not upstream.

Yeah this is only for CheriBSD. We've already got different jobs.

@jrtc27
Copy link
Member

jrtc27 commented Jan 24, 2021

I think we want to keep the existing jobs? Certainly keeping a non-ancient Ubuntu would be good otherwise we risk regressing support for more modern glibcs.

I agree we should but that's handled by our Jenkins tasks.

Not upstream.

Yeah this is only for CheriBSD. We've already got different jobs.

Only minor divergence currently?

@arichardson
Copy link
Member Author

Submitted upstream as https://reviews.freebsd.org/D28322. Will drop the macOS change since it doesn't work yet.

@arichardson arichardson deleted the gh-actions-os branch January 24, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants