procstat: Add a 'compartments' command to list c18n compartments #2276
Conversation
Co-authored-by: Dapeng Gao <[email protected]>
| struct cheri_c18n_compart { | ||
| ssize_t ccc_id; | ||
| char ccc_name[CHERI_C18N_COMPART_MAXNAME]; | ||
| char _ccc_pad[64]; /* Shrink as new fields added above. */ |
There was a problem hiding this comment.
I wonder if we should preemptively define a 'ccc_flags' field to capture concepts like "This is a non-default sub-library compartment", "this compartment can performance system calls", and similar?
| */ | ||
| if (len != sizeof(info) || | ||
| info.version != CHERI_C18N_INFO_VERSION || | ||
| info.comparts_gen % 2 != 0 || |
There was a problem hiding this comment.
I somewhat wondered if we wanted some sort of memory-barrier arrangement to ensure that we got a clean(ish) snapshot -- i.e., that if we saw the current generation, we saw all the stores we read from the compartment / string tables came before the generation number we read was stored, and that at the end of the sysctl function we haven't seen any stores that post-dated that generation-number store?
There was a problem hiding this comment.
Every iteration below we also re-read the generation number and check that it hasn’t changed. Presumably this achieves the desired effect?
| return; | ||
| } | ||
| if ((procstat_opts & PS_OPT_NOHEADER) == 0) | ||
| xo_emit("{T:/%5s %-19s %4s %-40s}\n", "PID", "COMM", "CID", |
There was a problem hiding this comment.
I always feel that 19 characters wide is quite a long slot for COMM, which most of the time uses list. Not sure if other procstat/ps modes might give less by default?
No description provided.