Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #2155 to 24.05 #2156

Closed
wants to merge 2 commits into from
Closed

Conversation

jrtc27
Copy link
Member

@jrtc27 jrtc27 commented Jul 19, 2024

No description provided.

jrtc27 added 2 commits July 19, 2024 04:11
For the height this doesn't matter unless auto_minheight is non-zero,
but for the width it does, as it would subtract off the maximum of
various things including the text width, which is clearly nonsense here.
All we want to do is compute how much space for content there is; what's
on other lines doesn't matter.

Fixes:	64f7073 ("bsddialog: Optionally truncate long mixedgauge labels and screens")

(cherry picked from commit 2283ee3)
The text in the [...] is 14 characters long, but that includes the
terminator that isn't rendered, so there are only 13 visible characters
(plus the square brackets).

(cherry picked from commit b2ad856)
@brooksdavis
Copy link
Member

Conceptually I'm ok with this if we don't want do the fast-forward dance. Ideally main would contain the release hash.

@jrtc27
Copy link
Member Author

jrtc27 commented Jul 19, 2024

Conceptually I'm ok with this if we don't want do the fast-forward dance. Ideally main would contain the release hash.

We could also just fast-forward main and releng/24.05. The only additional changes in dev are the KTLS fixes, and I don't understand why we didn't aim to get them in in the first place.

@brooksdavis
Copy link
Member

Conceptually I'm ok with this if we don't want do the fast-forward dance. Ideally main would contain the release hash.

We could also just fast-forward main and releng/24.05. The only additional changes in dev are the KTLS fixes, and I don't understand why we didn't aim to get them in in the first place.

OK, I'll start that process

@brooksdavis
Copy link
Member

Superseded by #2158

@brooksdavis brooksdavis deleted the 24.05-bsddialog-maxw-fix branch July 19, 2024 16:05
@bsdjhb
Copy link
Collaborator

bsdjhb commented Jul 22, 2024

Conceptually I'm ok with this if we don't want do the fast-forward dance. Ideally main would contain the release hash.

We could also just fast-forward main and releng/24.05. The only additional changes in dev are the KTLS fixes, and I don't understand why we didn't aim to get them in in the first place.

I didn't think the KTLS fixes were critical, and wouldn't have merged them to dev if we hadn't opened up dev, but they are also small, so a fast forward was ok.

bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Aug 20, 2024
 CTSRD-CHERI#2147 archive_string: clean up strncat_from_utf8_to_utf8 (36047967a)
 CTSRD-CHERI#2153 archive_match: check archive_read_support_format_raw()
       return value (0ce1b4c38)
 CTSRD-CHERI#2154 archive_match: turn counter into flag (287e05d53)
 CTSRD-CHERI#2155 lha: Do not allow negative file sizes (93b11caed)
 CTSRD-CHERI#2156 tests: setenv LANG to en_US.UTF-8 in bsdunzip test_I.c (83e8b0ea8)

Obtained from:		libarchive
Libarchive commit:	83e8b0ea8c3b07e07ac3dee90a8724565f8e53fd
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Aug 20, 2024
 CTSRD-CHERI#2147 archive_string: clean up strncat_from_utf8_to_utf8 (36047967a)
 CTSRD-CHERI#2153 archive_match: check archive_read_support_format_raw()
       return value (0ce1b4c38)
 CTSRD-CHERI#2154 archive_match: turn counter into flag (287e05d53)
 CTSRD-CHERI#2155 lha: Do not allow negative file sizes (93b11caed)
 CTSRD-CHERI#2156 tests: setenv LANG to en_US.UTF-8 in bsdunzip test_I.c (83e8b0ea8)

MFC after:	3 days
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Aug 20, 2024
 CTSRD-CHERI#2147 archive_string: clean up strncat_from_utf8_to_utf8 (36047967a)
 CTSRD-CHERI#2153 archive_match: check archive_read_support_format_raw()
       return value (0ce1b4c38)
 CTSRD-CHERI#2154 archive_match: turn counter into flag (287e05d53)
 CTSRD-CHERI#2155 lha: Do not allow negative file sizes (93b11caed)
 CTSRD-CHERI#2156 tests: setenv LANG to en_US.UTF-8 in bsdunzip test_I.c (83e8b0ea8)

MFC after:	3 days
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants