Skip to content

Commit

Permalink
mrs.3: weak symbol only works for static programs
Browse files Browse the repository at this point in the history
In dynamically linked programs, malloc_revoke isn't sufficently
preempted when the init() constructor is run so does not work.
Document this to allow the rest of the patch to land.
  • Loading branch information
brooksdavis committed Oct 23, 2023
1 parent 8768f57 commit 2939b17
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion lib/libc/stdlib/malloc/mrs/mrs.3
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@ administratively configured preferences
is set)
or system-wide defaults.
.It
The value of the
.Sy For stically linked programs,
the value of the
.Va malloc_revocation
variable.
.Va malloc_revocation
Expand All @@ -144,6 +145,8 @@ or
then
.Dv AT_BSDFLAGS
is ignored.
.Pp
.Sy This does not work for dynamically linked programs.
.El
.Pp
.\" XXX: this is not tied to mrs and probably belongs somewhere else
Expand Down

0 comments on commit 2939b17

Please sign in to comment.