Improve talk listing #605
Merged
Improve talk listing #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefetch the relationships used to avoid having to do 4 extra queries for each talk.
Listing only 25 talks per page makes browsing the talks harder than necessary. Increasing it to 100 makes it possible to show all talks for a small conference in a single page, while still avoiding performance issues in larger conferences.
terceiro
force-pushed
the
improve-talk-listing
branch
from
73d37a2 to
b37478a
Compare
|
FWIW the ci failure seems to due to psycopg/psycopg2#1293. |
terceiro
force-pushed
the
improve-talk-listing
branch
from
585021d to
b6ed3d1
Compare
stefanor
reviewed
Jun 20, 2021
stefanor
reviewed
Jun 20, 2021
|
Looks nice, I like it. |
terceiro
force-pushed
the
improve-talk-listing
branch
from
b6ed3d1 to
1dc176a
Compare
stefanor
reviewed
Jun 20, 2021
If multiple languages are configured, also display the language in an extra column.
terceiro
force-pushed
the
improve-talk-listing
branch
from
1dc176a to
6a8f84a
Compare
hodgestar
reviewed
Jun 21, 2021
hodgestar
approved these changes
Jun 21, 2021
terceiro
force-pushed
the
improve-talk-listing
branch
from
6a8f84a to
d2bcb07
Compare
terceiro
force-pushed
the
improve-talk-listing
branch
from
d2bcb07 to
dbe3b85
Compare
hodgestar
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this on DebConf21: