LHC Info code review PR #62
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or PPS HLT workflows
…Params and m_stringParams to LHCInfoPerLS
grzanka
commented
Jul 23, 2022
grzanka
commented
Jul 23, 2022
|
Hi @grzanka please add the new CondFormats to:
|
JanChyczynski
force-pushed
the
jc_lhcInfo_split
branch
3 times, most recently
from
7688366 to
bcc068e
Compare
JanChyczynski
force-pushed
the
jc_lhcInfo_split
branch
from
bcc068e to
6a2e73e
Compare
JanChyczynski
force-pushed
the
jc_lhcInfo_split
branch
from
87d9847 to
67071cc
Compare
JanChyczynski
force-pushed
the
jc_lhcInfo_split
branch
from
67071cc to
10cbd4a
Compare
ggovi
reviewed
Aug 31, 2022
| @@ -469,8 +504,7 @@ void LHCInfoPerLSPopConSourceHandler::getNewObjects() { | |||
| } | |||
|
|
|||
|
|
|||
| size_t nlumi = getLumiData(oms, lhcFill, startSampleTime, endSampleTime); | |||
| edm::LogInfo(m_name) << "Found " << nlumi << " lumisections during the fill " << lhcFill; | |||
| getLumiData(oms, lhcFill, startSampleTime, endSampleTime); | |||
There was a problem hiding this comment.
Can you explain the reason why the printout is no longer executed ?
There was a problem hiding this comment.
It's been moved to line 142, inside getLumiData https://github.com/CTPPS/cmssw/pull/62/files#diff-f26dd73d4300142b911cc877df1bcf2313392b1a0835c7a004d615fdc3f887b8R142
I've decided that getLumiData shouldn't return the number of lumisections it got from OMS but the number of buffered lumisections and the debug info about how many lumisections it has got from OMS should be inside the method.
…e of adding empty payloads
JanChyczynski
force-pushed
the
jc_lhcInfo_split
branch
from
258478f to
a83274c
Compare
JanChyczynski
force-pushed
the
jc_lhcInfo_split
branch
from
a83274c to
7cf8bac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR is not meant to be merged, its solely purpose is the discussion and review the code of new implementation of the LHCInfo classes