Ctpps diamond dqm 2021 #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes seem to be inline with the description. But before I can give my "+1", please resolve the conflict. |
grzanka
reviewed
Sep 12, 2019
grzanka
reviewed
Sep 12, 2019
|
My GitHub still says: "This branch cannot be rebased due to conflicts". |
|
+1 |
|
Thanks! again, a |
MatiXOfficial
pushed a commit
that referenced
this pull request
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
98-99: New variables declarations so more than one detector is seen.
232-234: initializing the above
267-341: multiple updates on histograms so we can see whole image
509-510: Updates on offset (so it is 0 now)
539-555: Removed old calculation of offset
567-579: Updated calculation of the detIDs for booking
906: Updated line to dynamically use detId
1050-1080: Added loop outside to take into account new detID