Fix setup script and add packaging improvements #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
|
I moved the someone rambling packaging discussion to its own issue, #58 . |
|
Wow, thank you very much for doing this! Looks good, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running into a bit of trouble building and running on Windows, I was up and running after a few teaks to
setup.pyand installing the proper compiler versions. However, while I was at it, I figured I'd contribute those fixes back here, and in the process I ended up doing some related cleanup and updating in setup.py as well as a few key additions that should make this ready to go for PyPI, if there is any interest—it certainly should make the project more accessible to newcomers, particularly for students and those newer the field, simplify package and dependency management for users, and increase visibility to reach a wider audience.Let me know if I can be of further help! I was also thinking of submitting another PR to do some baseline cleanup and standards-conformance issues (fixing crazy mixed line endings and enforcing universal newlines by .gitattributes, HTTPS links, explicit encoding declaration, standardized ISO 8601 dates, a few minor additional packaging improvements, and maybe some conservative linting), if you wouldn't mind. Thanks!