Updated SFU modules to slash commands

[chanchantang]

Description

In regard to issue #667

Converted def sfu() and def outline() to slash commands. Also rewrote existing commands to be more clean and DRY.

Things to Note:

• For outline(), I am unsure how to have the optional argument “next”, current setup as an input argument called arg
• There may be a better way to chunk _construct_fields()
• _construct_fields() could not use the info and schedule arguments, however it would require interaction to embed an error message. Unsure which is better
• For _split_course, I return an error using a third return value, there may be a better way to do this
• Image for thumbnail seems to be broken, so I removed it
• Room always seems to be TBD
• Apparently we do not need to use the json library since we can just use request library, I am unsure how while chunking the data
• For the courses() function, it does not chunk the get request, could be a concern
• Unsure how to support a help message

PR Checklist

All test cases done in the test cases section are passed except for required arguments now being shown in the Discord UI due to the command being converted from . to /

[modernNeo]

will review next weekend but @TitanVJ may want to take a crack at it first since he's the one who wrote and knows that command more intimately than I do.

[TitanVJ]

Everything looks good to me. Very nice work @chanchantang !!

[TitanVJ]

For outline(), I am unsure how to have the optional argument “next”, current setup as an input argument called arg

Maybe turn it into a boolean arg? call it next_term? something like that and have the description updated to say it lets you specifiy if you want to pull next terms information with a yes/no true/false.

_construct_fields() could not use the info and schedule arguments, however it would require interaction to embed an error message. Unsure which is better

What do you mean by this, looks like the code is using the arguments?

Apparently we do not need to use the json library since we can just use request library, I am unsure how while chunking the data

dont know why i made that comment, you can remove it.

Room always seems to be TBD

Looks like the outlines api has been updated and the building code and room number are no longer provided:
https://www.sfu.ca/outlines/help/api.html#courseOutline
you can just remove those bits of code.

For the courses() function, it does not chunk the get request, could be a concern

The outlines request is chunked because the response is sometimes too large, but that isn't a concern with the calendar api that's used in the courses() command. If there was an issue we would've encountered it by now since this codes been running for years.

@chanchantang my attempt at addressing some of your notes.

[chanchantang]

What do you mean by this, looks like the code is using the arguments?

This part of the code below in outline() can be put inside _construct_fields(), since info and schedule just rely on data.

wall_e/wall_e/extensions/sfu.py

Lines 322 to 333 in 985095b

	self.logger.debug('[SFU outline()] parsing data from get request')
	try:
	# Main course information
	info = data['info']
	# Course schedule information
	schedule = data['courseSchedule']
	except Exception:
	self.logger.debug('[SFU outline()] info keys didn\'t exist')
	await self._embed_message(interaction, 'SFU Course Outlines', 'SFU Outline Error',
	desc=err_desc)
	return

However, since that function also possibly embeds a message, we would also need to pass interaction. So the option is either, the current, _construct_fields(data, info, schedule) or _construct_fields(interaction, data).

[chanchantang]

Also forgot to mention, but I removed the help message, not sure how to support it with the slash commands.

[TitanVJ]

What do you mean by this, looks like the code is using the arguments?

This part of the code below in outline() can be put inside _construct_fields(), since info and schedule just rely on data.

wall_e/wall_e/extensions/sfu.py

Lines 322 to 333 in 985095b

	self.logger.debug('[SFU outline()] parsing data from get request')
	try:
	# Main course information
	info = data['info']
	# Course schedule information
	schedule = data['courseSchedule']
	except Exception:
	self.logger.debug('[SFU outline()] info keys didn\'t exist')
	await self._embed_message(interaction, 'SFU Course Outlines', 'SFU Outline Error',
	desc=err_desc)
	return

However, since that function also possibly embeds a message, we would also need to pass interaction. So the option is either, the current, _construct_fields(data, info, schedule) or _construct_fields(interaction, data).

I'd got w/ the ladder option, seems cleaner overall.

[TitanVJ]

Also forgot to mention, but I removed the help message, not sure how to support it with the slash commands.

That's fine, if someones stuck they can use the actual help command.

[chanchantang]

Oh, forgot to mention that the standard error message we embed relies on course_code and course_num, so instead of passing it to _construct_fields() I just changed it.

[modernNeo]

small fixes and then I will merge

[modernNeo]

unnecessary return

[modernNeo]

Suggested change

	self.logger.debug('[SFU outline()] parsing data from get request')
	self.logger.debug('[SFU _construct_fields()] parsing data from get request')

[modernNeo]

Suggested change

	self.logger.debug('[SFU outline()] info keys didn\'t exist')
	self.logger.debug('[SFU _construct_fields()] info keys didn\'t exist')