Support user defined sass options #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let end users define options that will be passed to sass-embedded during compilation. Omit outputStyle from configurable options to preserve sourcemaps paths: uswds#79. Note that includePaths is a legacy API option, so it doesn't need to be included in the types Omit<>. Provide a good out-of-box experience by defaulting to sass options {quietDeps: true}, so that deprecation warnings related to the user's own styles are raised, but those from USWDS styles are suppressed.
speck14
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
@mdmower-csnw Review +
This is especially nice:
Provide a good out-of-box experience by defaulting to sass options {quietDeps: true}, so that deprecation warnings related to the user's own styles are raised, but those from USWDS styles are suppressed.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let end users define options that will be passed to
sass-embeddedduring compilation. OmitoutputStylefrom configurable options to preserve sourcemaps paths: uswds#79. Note thatincludePathsis a legacy API option, so it doesn't need to be included in the typesOmit<>.Provide a good out-of-box experience by defaulting to sass options
{quietDeps: true}, so that deprecation warnings related to the user's own styles are raised, but those from USWDS styles are suppressed.