Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #337

Merged
merged 13 commits into from
Feb 9, 2024
Merged

Update dependencies #337

merged 13 commits into from
Feb 9, 2024

Conversation

Zeitsperre
Copy link
Member

No description provided.

@Zeitsperre Zeitsperre added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 12, 2024
@Zeitsperre Zeitsperre self-assigned this Jan 12, 2024
@Zeitsperre Zeitsperre requested a review from huard January 12, 2024 15:50
@Zeitsperre
Copy link
Member Author

@huard

For some reason, the Linux/Anaconda builds are segfaulting all over the place. I am completely at a loss. There are functionally no changes beyond the augmenting of a few versions (which are typically installed at a much higher version). There weren't any major software releases lately, so I can't say for certain it's even dependency-related.

My only theory is that it's affecting tests that depend on python-netcdf4 and geopandas (both use GDAL). If this is another GDAL issue, I wouldn't be surprised.

Any other ideas?

@huard
Copy link
Collaborator

huard commented Jan 12, 2024

Thread issues with netCDF happening because xdist runs tests in parallel ?

Also, why is the pydantic version not already set at > 2 ? I had done this in the pydantic PR already.

@huard
Copy link
Collaborator

huard commented Jan 12, 2024

Ahh... I may have done the change in pyproject.toml but not elsewhere...

@Zeitsperre
Copy link
Member Author

Thread issues with netCDF happening because xdist runs tests in parallel ?

macOS (conda) and the PyPI builds all run in parallel. No new releases of libnetcdf or hdf5 in more than a month. I don't think it's due to that. Most of the errors are popping up when GridWeightExtractor is called.

I can't test locally due to a weird bug with libgxx-ng (seeing this issue at raven-hydro as well). Something for next week.

Also, why is the pydantic version not already set at > 2 ? I had done this in the pydantic PR already.

This must have flown under the radar. pydantic was likely being reinstalled by pip in our tests...

@Zeitsperre Zeitsperre changed the title Update dependencies, re-enable autodoc-pydantic Update dependencies Jan 12, 2024
@coveralls
Copy link

Coverage Status

coverage: 81.476% (+0.07%) from 81.404%
when pulling fac0978 on deps-update
into 89c356c on master.

@Zeitsperre
Copy link
Member Author

This is a welcome surprise. I guess that the issues may have been due to Pandas or to some other conda packages.

@Zeitsperre Zeitsperre merged commit 4cce1ef into master Feb 9, 2024
16 checks passed
@Zeitsperre Zeitsperre deleted the deps-update branch February 9, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants