Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RavenGIS #127

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

RavenGIS #127

wants to merge 36 commits into from

Conversation

Zeitsperre
Copy link
Member

Overview

This PR fixes [issue id]

Changes:

  • Refactoring of the GIS utilities found in RavenPy into its own project

Related Issue / Discussion

#125

Additional Information

Links to other issues or sources.

@Zeitsperre
First pass at refactoring GIS functions out of RavenPy with their ass…
5db84b4 
…ociated tests, temporarily make RavenWPS rely on raven-gis-refactor branch of RavenGIS, synchronize RavenPy and RavenGIS with the same cookiecutter via cruft
@Zeitsperre Zeitsperre added the enhancement New feature or request label Aug 5, 2021
@Zeitsperre Zeitsperre requested a review from cjauvin August 5, 2021 21:23
@Zeitsperre Zeitsperre self-assigned this Aug 5, 2021
@Zeitsperre
Copy link
Member Author

Present state of affairs: Tests are passing, but the speed of tests test_generate_grid_weights_with_shp_input and test_generate_grid_weights_with_weight_rescaling is really slow. I imagine there are some optimizations that need to be worked out. Besides those, speed is comparable to GDAL implementations. Will begin cleaning up the PR here now.

@Zeitsperre Zeitsperre marked this pull request as ready for review August 11, 2021 19:19
@Zeitsperre
Copy link
Member Author

There's a very real possibility that the code will run faster without GDAL. I have some optimizing left to do, but I think the slowdowns in the GridWeight file formatter can be fixed with a cleaner approach. The original version of the code is triggered automatically if geopandas is installed (which depends on GDAL).

@Zeitsperre
Copy link
Member Author

I can't explain why the PyPI-noGDAL-based install is incredibly slow on some tests. The conda-forge build does not have GDAL and outperforms PyPI-GDAL builds by minutes. In any case, I need to move on for now,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjauvin cjauvin cjauvin left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Zeitsperre Zeitsperre

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeitsperre @cjauvin