Feature/initial value #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dylanwatsonsoftware, I would love to to get your opinions on this, given that you created the original feature request an PR. |
|
LGTM! ✅ The only thing that I can see missing compared to my original PR is the GitHub action. Though that is obviously unrelated to the actual feature, it does help prove that the code isn't totally broken 🤪 Thoughts @chrisbianca ? |
|
Hey @chrisbianca, did you have time to look into this by any chance? 🙂 |
|
@mauriceackel This looks great, thanks for the submission and pulling through the functionality that was clearly missed when I did the last refactor. I'll get a release out in the coming days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR related to #190 and #191.
It adds the possibility to define an initial value for the
useCollectionDataOnceuseCollectionDatauseDocumentDataOnceuseDocumentDatahooks.
It is heavily based on PR #191 but as this PR was merged to the 3.0.x branch, it is not part of the current version (i.e. 5.0.x).
I've slightly changed the code compared to #191 and I also fixed some typing issues.
@chrisbianca, please let me know if I could somehow help in making this part of version 5 swiftly.
Thanks, Maurice