Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Fix errors for undefined variables #459

Merged
merged 3 commits into from
Jan 10, 2022

Conversation

csc-felipe
Copy link
Contributor

@csc-felipe csc-felipe commented Jan 5, 2022

Description

This fixes errors that show in console due to vuex initial state having undefined variables.

Related issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  • Set values for variables that would otherwise be undefined.
  • Refactor truncate(), using only one implementation, and avoiding undefined errors.
  • Initialized the translation library for the login page.

Testing

  • Tests do not apply

Mentions

@csc-felipe csc-felipe self-assigned this Jan 5, 2022
@blankdots
Copy link
Contributor

if I understand what this does, that would be awesome to have, still looks like the integration tests fail for some reason, maybe those need adjusting or fixing 🤔

@csc-felipe csc-felipe merged commit f42ac80 into devel Jan 10, 2022
@csc-felipe csc-felipe deleted the bugfix/initial-state-errors branch January 10, 2022 11:58
@sampsapenna sampsapenna mentioned this pull request Jan 12, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants