use pyspelling as spellchecker #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blankdots
added
enhancement
|
Did you already run it against the code to see what happens? |
no, not yet, will try next week to see what happens |
|
Should we have the new files without the dot and inside the |
@csc-felipe done |
blankdots
force-pushed
the
refactor/spellcheck-action
branch
from
39ca68c to
0900266
Compare
add dictionary of files check docs and all markdown files adjust some spelling ignore Finnish words for spellchecking in lang.js
blankdots
force-pushed
the
refactor/spellcheck-action
branch
from
0900266 to
a0b826c
Compare
|
merging this as it does not introduce any breaking changes, just spellchecking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this worked really well when introduced in CSCfi/metadata-submitter#316 so we should adopt it.
Related issues
Type of change
Changes Made
pyspellingin github action as a improved alternative tomisspellwhich is not that maintainedTesting
Mentions
I could not figure out the regex how to make it work https://facelessuser.github.io/pyspelling/filters/context/ to filter out just the
fi:portion of thelang.jsfile (fi:((.|\n)*)` worked in other regex testers but not with the pyspelling - would appreciate some help if anyone has any ideas.