don't change state after application started #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blankdots
force-pushed
the
bugfix/chaing-state-of-server
branch
from
c5e59e5 to
5513f8a
Compare
blankdots
changed the title
blankdots
force-pushed
the
bugfix/chaing-state-of-server
branch
from
5513f8a to
be1b131
Compare
csc-felipe
reviewed
Dec 30, 2021
blankdots
force-pushed
the
bugfix/chaing-state-of-server
branch
2 times, most recently
from
46b4fe9 to
2008d9e
Compare
corresponds to https://github.com/aio-libs/aiohttp/blob/master/aiohttp/web_app.py#L146 we remove some tests for now
blankdots
force-pushed
the
bugfix/chaing-state-of-server
branch
from
2008d9e to
7cbdeba
Compare
csc-felipe
approved these changes
Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
corresponds to: https://github.com/aio-libs/aiohttp/blob/master/aiohttp/web_app.py#L146 and https://docs.aiohttp.org/en/stable/web_advanced.html#background-tasks
Related issues
Type of change
Changes Made
on_startupfor theweb.ApplicationTesting
Mentions
Pending Testing ... to see if it behaves as it should