Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform that container and objects can't be renamed. #436

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

csc-felipe
Copy link
Contributor

Description

Shows a meassage saying that container and objects can't be renamed. The tag featured introduced an edit view for container and objects, which may lead to the impression that somehow container and object names could be edited. This message tries to clarify that they can't.

@sampsapenna, please check the Finnish words. :)

image

Related issues

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

Testing

  • Tests do not apply

Mentions

@csc-felipe csc-felipe self-assigned this Dec 22, 2021
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would phrase it differently, but other than that LGTM

swift_browser_ui_frontend/src/common/lang.js Outdated Show resolved Hide resolved
@csc-felipe csc-felipe force-pushed the feature/inform-norename branch from 4a7d28c to 6318ba4 Compare December 28, 2021 11:30
@csc-felipe
Copy link
Contributor Author

@sampsapenna, could you check the language, please?

This is how it looks like now.
image
image

Copy link
Member

@sampsapenna sampsapenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor alterations to the Finnish language, otherwise LGTM.

swift_browser_ui_frontend/src/common/lang.js Outdated Show resolved Hide resolved
swift_browser_ui_frontend/src/common/lang.js Outdated Show resolved Hide resolved
swift_browser_ui_frontend/src/common/lang.js Outdated Show resolved Hide resolved
@csc-felipe csc-felipe force-pushed the feature/inform-norename branch from 6318ba4 to fa8e832 Compare December 28, 2021 14:13
@csc-felipe csc-felipe dismissed sampsapenna’s stale review December 28, 2021 14:15

Thanks for explaining, it's updated now.

@csc-felipe csc-felipe merged commit 2733e5e into devel Dec 28, 2021
@csc-felipe csc-felipe deleted the feature/inform-norename branch December 28, 2021 14:50
@sampsapenna sampsapenna mentioned this pull request Jan 12, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants