-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abort large number of fetch requests #435
Conversation
33d1686
to
3fc73e2
Compare
3fc73e2
to
cd837a1
Compare
Loading tags is unnecessary when navigating to another page, and it keeps browser resources busy. This change cancels those requests when browsing away.
cd837a1
to
18ef1f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this sparks the idea of displaying a message, e.g. after 30 sec or so, that the loading time will take longer for this request and data is being processed and I assume this can be handled in a different PR.
Should we add this abortcontroller to errorCaptured
https://vuejs.org/v2/api/#errorCaptured as well ?
otherwise seems ok.
There is an issue for showing long background ops #425. I'm not sure if I understood what do you mean with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solves the issue with existing fetch calls preventing updating the new route view when etc. opening a container, approved. The experience was considerably faster now, with projects that have hundreds of buckets.
Don't we need to abort the calls when an error is captured, or we will never have that case ? |
That would be good if we know what kind of errors might happen. I think first we should be able to observe what errors people are having, so we don't have to guess. |
Description
Loading tags is unnecessary when navigating to another page, and it
keeps browser resources busy. This change cancels those requests when
browsing away.
Related issues
Type of change
Changes Made
Container and object view can cancel loading of tags when moving away of the page using an AbortController.
Testing
Mentions