-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically refresh ACL information in sharing db #422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the ACLs yet, and I did not run it, as I haven't been running the whole environment yet. Thus, only looked at the code and made the review as a comment.
I would have preferred if the formatting had been a separate PR, as there's a lot of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if my understanding is correct this #69 is not required any more.
We need to add a follow-up issue to add some integration (or cypress) tests for this. A test could look like:
- we log in we see some shared containers
- we update the db in the background
- we re-login the users we see the updated shared containers
I have not tested, however the code looks good and if we spot any issues I assume we will see them in practice.
also this needs a rebase
Opened an issue for the integration tests in #424 #69 is not relevant to this PR, but it would go nicely together with this change. This PR was about keeping the database information as current as possible. I'd like to keep it open still. Rebase will happen shortly 👍🏼 |
Yup, the formatting was an unfortunate mishap with vscode auto-formatting that I noticed too late, thus it made its way in |
ddd5158
to
94d71b4
Compare
Description
Add automatic synchronization for ACL information in sharing database. I.e. current container access additions, removals, edits and container removals.
Previously the sharing information had a tendency towards containing stale data, since people would also access the sharing information in the CLI, remove containers, etc. leading to ACLs changing without updates.
Related issues
Type of change
Changes Made
Testing
Mentions