Allow a person to tag buckets. #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cypress is clicking the wrong switch |
then we need a better selector for that switch, or something is off with clicking the parent |
blankdots
reviewed
Dec 1, 2021
csc-felipe
force-pushed
the
feature/usertags
branch
2 times, most recently
from
7687ed5 to
fa6bdea
Compare
csc-felipe
changed the title
csc-felipe
force-pushed
the
feature/usertags
branch
from
fa6bdea to
373a80a
Compare
sampsapenna
reviewed
Dec 3, 2021
sampsapenna
reviewed
Dec 3, 2021
sampsapenna
reviewed
Dec 3, 2021
sampsapenna
previously requested changes
Dec 3, 2021
csc-felipe
force-pushed
the
feature/usertags
branch
from
373a80a to
0d8239f
Compare
This feature has a frontend and backend part. From the frontend, user can create tags at the create bucket screen. On the backend, the tags are stored as metadata in the swift object store.
csc-felipe
force-pushed
the
feature/usertags
branch
from
0d8239f to
406edff
Compare
csc-felipe
dismissed stale reviews from blankdots and sampsapenna
Added entry to API docs
blankdots
approved these changes
Dec 7, 2021
sampsapenna
approved these changes
Dec 7, 2021
csc-felipe
added a commit
that referenced
this pull request
Dec 9, 2021
This is a continuation to the tagging buckets feature from PR #419. The openApi spec supports tuples in 3.1 with prefixItems. We may want to change the api docs when that comes into use.
3 tasks
csc-felipe
added a commit
that referenced
this pull request
Dec 9, 2021
This is a continuation to the tagging buckets feature from PR #419. The openApi spec supports tuples in 3.1 with prefixItems. We may want to change the api docs when that comes into use.
csc-felipe
added a commit
that referenced
this pull request
Dec 10, 2021
This is a continuation to the tagging buckets feature from PR #419. The openApi spec supports tuples in 3.1 with prefixItems. We may want to change the api docs when that comes into use.
csc-felipe
added a commit
that referenced
this pull request
Dec 10, 2021
This is a continuation to the tagging buckets feature from PR #419. The openApi spec supports tuples in 3.1 with prefixItems. We may want to change the api docs when that comes into use.
csc-felipe
added a commit
that referenced
this pull request
Dec 10, 2021
This is a continuation to the tagging buckets feature from PR #419. The openApi spec supports tuples in 3.1 with prefixItems. We may want to change the api docs when that comes into use.
csc-felipe
added a commit
that referenced
this pull request
Dec 10, 2021
This is a continuation to the tagging buckets feature from PR #419. The openApi spec supports tuples in 3.1 with prefixItems. We may want to change the api docs when that comes into use.
csc-felipe
added a commit
that referenced
this pull request
Dec 10, 2021
This is a continuation to the tagging buckets feature from PR #419. The openApi spec supports tuples in 3.1 with prefixItems. We may want to change the api docs when that comes into use.
2 tasks
csc-felipe
added a commit
that referenced
this pull request
Dec 10, 2021
This is a continuation to the tagging buckets feature from PR #419. The openApi spec supports tuples in 3.1 with prefixItems. We may want to change the api docs when that comes into use.
csc-felipe
added a commit
that referenced
this pull request
Dec 15, 2021
This is a continuation to the tagging buckets feature from PR #419. The openApi spec supports tuples in 3.1 with prefixItems. We may want to change the api docs when that comes into use.
csc-felipe
added a commit
that referenced
this pull request
Dec 15, 2021
This is a continuation to the tagging buckets feature from PR #419. The openApi spec supports tuples in 3.1 with prefixItems. We may want to change the api docs when that comes into use.
csc-felipe
added a commit
that referenced
this pull request
Dec 20, 2021
This is a continuation to the tagging buckets feature from PR #419. The openApi spec supports tuples in 3.1 with prefixItems. We may want to change the api docs when that comes into use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gives a person the possibility to add or remove tags from a bucket. Includes the ability to show or hide tags when browsing the buckets.
Please, check the Finnish language :)
Related issues
Related to #85.
Type of change
Changes Made
Added backend for updating metadata for a bucket. Added UI for displaying tags for containers, as well as hiding them. There is a new button, called 'Edit', which makes it possible to edit a bucket's tags. When creating a new Bucket, it's possible to add tags to it.
Tags are not displayed in the bucket view (after double click on a bucket). There's no edit button on that page either.
Testing
Mentions
Thanks to @sampsapenna for solving my javascript sync/async mess.