-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload encryption with WASM #395
Conversation
7099cd4
to
15932a3
Compare
5d10747
to
b765375
Compare
b765375
to
96ce7b4
Compare
Latest push includes multiple changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image versions (alpine) need updating and we need to have our own libcrypt4gh repo at CSCfi
org.
small improvements in the docs need to be managed.
Note: I think we need to add follow-up issue for testing the C code as well as cypress tests to test the encryption interaction in front-end
Suggestion (not a change request): Instead of building the wasm as part of the image we can build it as part of the CI and add a conditional in the final image if that binary exists we enable that feature if not we don't. This will have the benefit of having fewer images to handle and keep track of.
Will come back with more suggestions after I test as well
there could be some other UI improvements, however let us tackle them as part of another issue. |
Description
Upload encryption using the existing upload runner ecosystem with
resumable.js
. Encryption is done usinglibcrypt4gh
written in C and compiled with WebAssembly as a target.Dockerfile-build-crypt
andDockerfile-build-crypt-devel
handle building the encryption into the UI as of now.Related issues
Type of change
Changes Made
libcrypt4gh
in CTesting
Mentions