bump to 1.0.0rc15 #124
Merged
bump to 1.0.0rc15 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvaltia
reviewed
Feb 9, 2021
| RUN pip install --upgrade pip && \ | ||
| pip install -r /root/swift_ui/requirements.txt && \ | ||
| pip install /root/swift_ui | ||
|
|
||
| FROM python:3.8-alpine3.12 | ||
| FROM python:3.8-alpine3.13 | ||
|
|
||
| RUN apk add --no-cache --update bash | ||
|
|
There was a problem hiding this comment.
Not required for right now, but would make more sense to have just one docker image. If the files differ, they could be added as configmaps instead.
There was a problem hiding this comment.
for this dockerfile BACKEND builds the packages while the layer you pointed has the binaries
If we take into consideration other swift-ui services sure, that could be a way.
vvaltia
reviewed
Feb 9, 2021
vvaltia
previously approved these changes
Feb 9, 2021
teemukataja
previously approved these changes
Feb 9, 2021
breaking changes in cryptography require rust > 1.45 which is in alpine 3.13
also fix to point to the correct key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update docker image with rust in build, needed by cryptography package https://cryptography.io/en/latest/installation.html#rust
There was an
OSErrorexception in health endpoint when other endpoints are down so decided to catch them all (shameless Pokemon reference)Related issues
Type of change
Changes Made
Testing
Mentions