Skip to content

Commit

Permalink
Update Changelog and have better function description
Browse files Browse the repository at this point in the history
  • Loading branch information
hannyle authored and Hang Le committed Oct 26, 2023
1 parent ff7ea20 commit 7837ee8
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Separate upload and download workers
- Use direct file system writes if available on system
- Move upload, download fetch calls to workers to reduce messaging overhead
- (GL #1145) Added new api for modifying write access from container's access control list

### Changed

Expand Down
6 changes: 4 additions & 2 deletions swift_browser_ui/ui/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -685,8 +685,10 @@ async def remove_container_acl(request: aiohttp.web.Request) -> aiohttp.web.Resp
raise aiohttp.web.HTTPNotFound()


async def modify_container_acl(request: aiohttp.web.Request) -> aiohttp.web.Response:
"""Modify sharing permission from container acl."""
async def modify_container_write_acl(
request: aiohttp.web.Request,
) -> aiohttp.web.Response:
"""Modify write access for a project from container acl."""
session = await aiohttp_session.get_session(request)
request.app["Log"].info(
"API call to modify projects fom container ACL from "
Expand Down
6 changes: 4 additions & 2 deletions swift_browser_ui/ui/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
get_os_user,
get_shared_container_address,
get_upload_session,
modify_container_acl,
modify_container_write_acl,
os_list_projects,
remove_container_acl,
remove_project_container_acl,
Expand Down Expand Up @@ -245,7 +245,9 @@ async def on_prepare(
"/api/access/{project}/{container}/{receiver}",
remove_project_container_acl,
),
aiohttp.web.put("/api/access/{project}/{container}", modify_container_acl),
aiohttp.web.put(
"/api/access/{project}/{container}", modify_container_write_acl
),
aiohttp.web.get("/api/meta/{project}", swift_get_project_metadata),
aiohttp.web.get(
"/api/meta/{project}/{container}", swift_get_metadata_container
Expand Down

0 comments on commit 7837ee8

Please sign in to comment.