Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add some small fixes #42

Merged
merged 3 commits into from
Jun 11, 2020
Merged

Feature/add some small fixes #42

merged 3 commits into from
Jun 11, 2020

Conversation

otahontas
Copy link
Contributor

Description

Small PR, fixing some stuff here and there.

Related issues

Fixes #41

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  • Added check multiple file form sends on rest api submit endpoint and test for this
  • Fixed some out-of-date stuff from docs, formatted docs again
  • Removed initing objects to variable when variables were only used once, so code style is in sync with changes @csc-jm made yesterday.

Testing

  • Unit Tests

Mentions

Just a note for future: I tried to make _extract_xml_upload to return only one tuple when extract_one is set to true, but mypy doesn't apparently like functions/methods that return many types. More about it here: python/typing#566

otahontas added 3 commits June 11, 2020 07:51
@otahontas
Fix out-of-date stuff from README and formatting from contribution gu…
f0a49c6 
…idelines
@otahontas
Add check for submitting only one file in rest api create endpoint
9a9d79e 
Submitting only file is checked now during extraction in private
method.

Also fixes some minor things related to code readability.
@otahontas
Fix release version and add correct authors to project
9931841
@otahontas otahontas added the enhancement New feature or request label Jun 11, 2020
@otahontas otahontas self-assigned this Jun 11, 2020
@otahontas otahontas requested review from csc-jm-zz and blankdots June 11, 2020 06:03
csc-jm-zz
csc-jm-zz approved these changes Jun 11, 2020
View reviewed changes
Copy link

@csc-jm-zz csc-jm-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea looks a lot cleaner

@otahontas otahontas merged commit bfe5575 into develop Jun 11, 2020
@otahontas otahontas deleted the feature/add-some-small-fixes branch June 11, 2020 07:26
@otahontas otahontas mentioned this pull request Jun 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csc-jm-zz csc-jm-zz csc-jm-zz approved these changes

@blankdots blankdots Awaiting requested review from blankdots

Assignees

@otahontas otahontas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@otahontas @csc-jm-zz