Feature/add validation endpoint #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otahontas
reviewed
Jun 10, 2020
There was a problem hiding this comment.
This looks fine to me, code is also easy to follow. Couple of things to note:
- endpoint now takes any amount of xml files and validates them. Maybe response should have "areValid" or either restrict its usage to handling only one xml file?
- I don't think adding that much inline comments is necessary, that validation part is quite clear now
blankdots
suggested changes
Jun 10, 2020
Co-authored-by: Stefan Negru <[email protected]>
…tadata-submitter into feature/add-validation-endpoint merges fixes made in remote and local repo
|
requested changes made |
otahontas
approved these changes
Jun 10, 2020
otahontas
approved these changes
Jun 10, 2020
blankdots
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR includes an endpoint for XML validation that responds with a json object that includes boolean value for key "isValid" and a text string for the reason of failure if xml is invalid. Whether or not json response was required for this operation, I found responding with json to be substantially faster for whatever reason when xml was invalid against schema.
Related issues
Fixes #22
Type of change
Changes Made
Testing