Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically Release to TestFlight & Add Feature Flags to Control the Firebase Environment #48

Merged
merged 7 commits into from
Feb 26, 2023

Conversation

PSchmiedmayer
Copy link
Member

@PSchmiedmayer PSchmiedmayer commented Feb 24, 2023

Automatically Release to TestFlight & Add Feature Flags to Control the Firebase Environment

💡 Proposed solution

  • This PR adds a mechanism to automatically release the application to the TestFlight testers.
  • Adds the --useFirebaseEmulator feature flag that defines if the application should connect to the local firebase emulator. Always set to true when using the iOS simulator.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer PSchmiedmayer requested a review from a team February 24, 2023 07:50
Copy link
Contributor

@jenlmoore jenlmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks

@jenlmoore jenlmoore enabled auto-merge (squash) February 26, 2023 01:27
@PSchmiedmayer PSchmiedmayer changed the title Automatically Release to TestFlight Automatically Release to TestFlight & Add Feature Flags to Control the Firebase Environment Feb 26, 2023
@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Merging #48 (a8f6cfe) into main (be83c4d) will increase coverage by 0.39%.
The diff coverage is 55.18%.

❗ Current head a8f6cfe differs from pull request most recent head a0ab8c2. Consider uploading reports for the commit a0ab8c2 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   88.24%   88.63%   +0.39%     
==========================================
  Files          51       50       -1     
  Lines        1521     1529       +8     
==========================================
+ Hits         1342     1355      +13     
+ Misses        179      174       -5     
Impacted Files Coverage Δ
...tahModules/Sources/UtahProfile/EditPhotoView.swift 0.00% <0.00%> (ø)
UtahModules/Sources/UtahProfile/FormView.swift 0.00% <0.00%> (ø)
...ules/Sources/UtahProfile/UserInformationView.swift 91.18% <91.18%> (ø)
Utah/UtahAppDelegate.swift 97.73% <93.75%> (-2.27%) ⬇️
Utah/UtahAppTestingSetup.swift 100.00% <100.00%> (ø)
...UtahOnboardingFlow/AccountSetup/AccountSetup.swift 97.92% <100.00%> (+0.22%) ⬆️
...ahModules/Sources/UtahOnboardingFlow/Welcome.swift 89.19% <100.00%> (ø)
UtahModules/Sources/UtahProfile/HeaderBanner.swift 100.00% <100.00%> (ø)
UtahModules/Sources/UtahProfile/ProfileView.swift 100.00% <100.00%> (ø)
UtahUITests/ProfileTests.swift 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f898ac...a0ab8c2. Read the comment docs.

@jenlmoore jenlmoore merged commit 2c674e3 into main Feb 26, 2023
@jenlmoore jenlmoore deleted the feature/firebaseSetup branch February 26, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants