Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bal 185 gp new games #186

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Conversation

gperissetcelteeka
Copy link
Collaborator

New Games

♻️ Current situation & Problem

Describe the current situation (if possible, with an exemplary (or real) code snippet and/or where this is used)
Please link any open issue that is addressed with this PR
#185

💡 Proposed solution

Describe the solution and how this affects the project and internal structure

⚙️ Release Notes

Add a summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented if it appends or changes the public interface.

➕ Additional Information

Provide some additional information if possible

Related PRs

Reference the related PRs

Testing

Are there tests included? If yes, which situations are tested, and which corner cases are missing?

Reviewer Nudging

Where should the reviewer start? Where is a good entry point?

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@gperissetcelteeka gperissetcelteeka enabled auto-merge (squash) November 3, 2023 20:39
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #186 (f9bdbd6) into main (f4d6657) will decrease coverage by 0.04%.
The diff coverage is 1.94%.

❗ Current head f9bdbd6 differs from pull request most recent head 0e51288. Consider uploading reports for the commit 0e51288 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #186      +/-   ##
========================================
- Coverage   3.81%   3.77%   -0.04%     
========================================
  Files        133     133              
  Lines      10947   11076     +129     
========================================
  Hits         417     417              
- Misses     10530   10659     +129     
Files Coverage Δ
Balance/Balance.swift 82.09% <100.00%> (ø)
Balance/Utils/BalanceExtensions.swift 4.17% <ø> (ø)
Balance/Utils/Constant.swift 0.00% <ø> (ø)
Balance/Home/Home.swift 0.00% <0.00%> (ø)
Balance/Profile/ProfileCellView.swift 0.00% <0.00%> (ø)
Balance/Chill/ChillCellView.swift 0.00% <0.00%> (ø)
Balance/Distraction/DistractionCellView.swift 0.00% <0.00%> (ø)
Balance/Distraction/Games/GamesCellView.swift 0.00% <0.00%> (ø)
Balance/Home/CellView.swift 0.00% <0.00%> (ø)
Balance/Home/NavigationView.swift 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4d6657...0e51288. Read the comment docs.

Copy link
Collaborator

@sebastianricaldoni sebastianricaldoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 🙌

@gperissetcelteeka gperissetcelteeka merged commit aa396f4 into main Nov 8, 2023
2 of 3 checks passed
@gperissetcelteeka gperissetcelteeka deleted the feature/BAL-185-GP-NewGames branch November 8, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants