Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual testing folder #205

Merged
merged 17 commits into from
Nov 7, 2016
Merged

Manual testing folder #205

merged 17 commits into from
Nov 7, 2016

Conversation

INCENDE
Copy link

@INCENDE INCENDE commented Nov 6, 2016 •
edited
Loading

  • Sample data
  • Testing script

@burnflare
Copy link

When I checked the sample data yesterday, a lot of the events were very old because the data set was created last week.

Update the dataset so that it's most relevant when looking at it on Wednesday for our demo. Ideally let's only have 1 or 2 max Overdue items, maybe 3-4 due soon items and rest due later items in the left column. Completed tasks on the right column should also look 'nice' when loaded on Wednesday. So let's sample data based on that

@fanwgwg
Copy link

fanwgwg commented Nov 6, 2016

@INCENDE can check the test script?

@INCENDE
Copy link
Author

INCENDE commented Nov 6, 2016

Script looks good. Can add load and sync

@fanwgwg fanwgwg mentioned this pull request Nov 6, 2016
Closed
@INCENDE
Copy link
Author

INCENDE commented Nov 6, 2016

@burnflare is there a reason the sync tests are failing in this branch?

@burnflare
Copy link 

    {
      "code" : 403,
      "errors" : [ {
        "domain" : "usageLimits",
        "message" : "Calendar usage limits exceeded.",
        "reason" : "quotaExceeded"
      } ],
      "message" : "Calendar usage limits exceeded."
    }

Damn it, thought this might happen

@burnflare
Copy link

Google Calendar is rate limiting my test user after it tried to communicate with it too many times.

@INCENDE INCENDE mentioned this pull request Nov 6, 2016
Closed
@burnflare
Copy link

@INCENDE You can merge this now

rachx
rachx reviewed Nov 6, 2016
View reviewed changes
src/test/data/ManualTesting/testScript.md
| Hour:Minute | 10:30 |
| Hour.Minute | 10.30 |
| Relative time | this morning, this afternoon, tonight |

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to match user guide again tmr

src/test/data/ManualTesting/testScript.md
### 3. Add a task with event time
Type `add submit essay by 10pm`
#### Result
A new task named "submit essay" is created in the **Do It Soon** column, with its deadline under the name the this task. Also, it is highlighted in purple borders.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add go for church camp from 20 nov 2pm to 25 nov 5pm
event time not deadline

src/test/data/ManualTesting/testScript.md
Type `add submit essay by 10pm`
#### Result
A new task named "submit essay" is created in the **Do It Soon** column, with its deadline under the name the this task. Also, it is highlighted in purple borders.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to add escape character task

src/test/data/ManualTesting/testScript.md
Task with index 23 now has a deadline, and it is shifted to **Do It Soon** column with a new index. Also, it is highlighted in purple borders.

###3. Schedule a task with event time
Type `schedule 14 from 13 nov 2pm to 4pm`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schedule 14 from 13 nov 2pm to 13 nov 4pm
(if they check after 13 nov, they might not get the intended result)

src/test/data/ManualTesting/testScript.md

>Here is the *format*:

>* `mark <id>...` - mark all the tasks identified by `<id>`(s) as completed. Each `<id>` must be a positive number and in the most recent to-do list displayed.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the main user guide. id are separated by commas or space and can also be inputed as a range

src/test/data/ManualTesting/testScript.md

Type `find cs2103`
####result
Tasks containing `cs2103` in their names will be listed out.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full word, case insensitive

src/test/data/ManualTesting/testScript.md
####Result
1. After the first step, `s` is created as an alias command for `schedule`, and you can now use both `s` and `schedule` to reschedule a task.
2. After the second step, task with index 1 is rescheduled to be by today 10pm.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering. are we supposed to show that we handle edge cases
e.g. alias mark add

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already say that the <your command> cannot be one of the <original command>

@burnflare burnflare merged commit 0834fc1 into master Nov 7, 2016
@rachx
Copy link

rachx commented Nov 7, 2016

@fanwgwg please update with the changes

@burnflare burnflare deleted the manual-testing-folder branch November 7, 2016 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachx rachx rachx left review comments

@fanwgwg fanwgwg fanwgwg left review comments

@burnflare burnflare burnflare approved these changes

Assignees

@INCENDE INCENDE

@fanwgwg fanwgwg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@INCENDE @burnflare @fanwgwg @rachx