Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui enhancements #194

Merged
merged 13 commits into from
Nov 5, 2016
Merged

Ui enhancements #194

merged 13 commits into from
Nov 5, 2016

Conversation

fanwgwg
Copy link

@fanwgwg fanwgwg commented Nov 2, 2016

  • Changed some colors
  • Inline find command message
  • Remove seconds in the status bar
  • Set the max height/width of pop up window to be main window height/width
  • Added some shortcut key gui test
  • Fix the bug during demo that ctrl-H doesn't go back to main window

Fixes #193

@fanwgwg fanwgwg closed this Nov 2, 2016
@burnflare
Copy link

@fanwgwg Just fyi there's no need to make a PR to run Travis. Travis is always running on all pushed branches. You can see their build status here https://travis-ci.org/CS2103AUG2016-W11-C2/main/branches

@fanwgwg
Copy link
Author

fanwgwg commented Nov 2, 2016

hahah just realised that so I close it for now

@fanwgwg fanwgwg reopened this Nov 3, 2016
@burnflare
Copy link

@fanwgwg Is this ready to review? If so, can attach screenshot?

@fanwgwg
Copy link
Author

fanwgwg commented Nov 4, 2016

screen shot 2016-11-04 at 23 01 37 This is the updated color scheme, is it fine? @burnflare @INCENDE @rachx

@rachx
Copy link

rachx commented Nov 5, 2016

When i pulled the branch, it looks like
image
The overdue color is not very obvious

@fanwgwg : I think we can use the color scheme of the screenshot you took 👍 . Change and merge

@fanwgwg fanwgwg merged commit 6752567 into master Nov 5, 2016
@burnflare
Copy link

@fanwgwg was the change made before merging?

@fanwgwg
Copy link
Author

fanwgwg commented Nov 5, 2016

I don't think there is any change needed, cuz I've already made the changes before rachael asked about, so it could be that she didn't pull the latest changes?

@rachx rachx deleted the ui-enhancements branch November 5, 2016 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants