Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Calendar Integration #192

Merged
merged 39 commits into from
Nov 6, 2016
Merged

Google Calendar Integration #192

merged 39 commits into from
Nov 6, 2016

Conversation

burnflare
Copy link

@burnflare burnflare commented Nov 2, 2016

Usage instructions

  • sync on (First time, a auth screen would come up on your browser. Subsequent time this does not happen)
  • add anything with both start and end time. This would get synced to a new "Agendum Calendar" in your Google Calendar
  • sync off turn off syncing

Not ready for merging

@burnflare burnflare changed the title Initial Google Calendar support Google Calendar Integration Nov 4, 2016
@burnflare
Copy link
Author

@rachx @INCENDE @fanwgwg Please test! It works as the description says in #84

@burnflare
Copy link
Author

@INCENDE Could you test functionality and approve?

@INCENDE
Copy link

INCENDE commented Nov 6, 2016

Seems to be working fine. Are you going to add more tests to increase the coverage though? @burnflare

@burnflare
Copy link
Author

This latest commit is pretty much all I can do. Added full coverage to all the new files except for SyncProviderGoogle. This one is hard to test because of its dependency of actually exchange OAuth tokens with Google..

@burnflare
Copy link
Author

I just thought of a way to test the Google class! Will work on it.

@burnflare
Copy link
Author

@INCENDE There you go! Managed to test the GoogleCalendar files. 92% now

@burnflare burnflare self-assigned this Nov 6, 2016
Copy link

@INCENDE INCENDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@burnflare burnflare merged commit cef6251 into master Nov 6, 2016
@burnflare burnflare deleted the google-calendar branch November 6, 2016 07:34
@burnflare burnflare mentioned this pull request Nov 6, 2016
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants