-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs #149
Update docs #149
Conversation
- Make it more informal like 2101, directly address the user
- Alias supports multiple aliases - Unalias only support removing the alias command
…pdate-guides-for-v0.4 # Conflicts: # docs/DeveloperGuide.md # docs/UserGuide.md
Updated about us again (add more features and change the links to match the sub-headers of the new user guide)) |
Tick if you are okay with the files and ready to merge. Rachael
Weiguang
Justin
Vishnu
|
…2016-W11-C2/main into update-guides-for-v0.4
@@ -74,7 +75,8 @@ protected Stage createDialogStage(String title, Stage parentStage, Scene scene) | |||
* @param iconSource e.g. {@code "/images/help_icon.png"} | |||
*/ | |||
protected void setIcon(String iconSource) { | |||
primaryStage.getIcons().add(AppUtil.getImage(iconSource)); | |||
// primaryStage.getIcons().add(AppUtil.getImage(iconSource)); | |||
primaryStage.getIcons().add(new Image(this.getClass().getResourceAsStream(iconSource))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there commented code here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, what does this code change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O forgot to delete it !!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To merge after addressing commented code
should we add sync interface in the diagram? |
@rachx To the Model diagram? Can you help me do it, I don't have PPT installed. 🎱 |
Shifted the to-dos here. Fixes #104
Developer Guide